ES|QL: Skip FORK tests for CCS for now #127309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioanatia
added
>non-issue
>test
carlosdelest
approved these changes
Apr 24, 2025
Member
carlosdelest
left a comment
carlosdelest
left a comment
There was a problem hiding this comment.
I'm OK with this, but should we instead use muted-tests.yml and open an issue so we keep track of this?
Contributor
Author
I'm using the same pattern we have for INLINESTATS and unmapped fieds: FORK might be used when testing RRF and RERANK (if I am not mistaken, there's a test for using RERANK with FORK and RRF). Until we figure out why CCS suddenly has flaky specs, I don't want to make it a requirement when adding a test that's using FORK that's not in the Figuring out the CCS failures is tracked in #121950 |
23 tasks
This was referenced Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We see a bunch of new failures for multi clusters
#127268
#127279
#127304
#127272
All these failures happened in the last 24h - most likely there are somehow related to #126705 which was merged last week.
However I am not sure why we have not seen these types of failures earlier.
Most likely all FORK related tests will fail with the same type of error for multi clusters - I haven't seen any for multi or single node tests.
I am skipping the FORK tests for multi clusters for now.